[opendmarc-dev] Possible bug in dmarcf_config_reload function

[Federico Omoto]

On Wed, Aug 24, 2016 at 4:01 AM, Juri Haberland <juri at sapienti-sat.org>
wrote:

> On 2016-08-24 01:10, Federico Omoto wrote:
>
>> Hi!
>>
>
> Hello Federico,
>
> When the opendmarc_tld_read_file() is called inside
>> opendmarc_policy_library_init(), it's called as:
>>
>> opendmarc_tld_read_file(Opendmarc_Libp->tld_source_file, "//", "*.", "!")
>>
>> But when it's called from dmarcf_config_reload(), it's called as:
>>
>> opendmarc_tld_read_file(new->conf_pslist, "#", NULL, NULL)
>>
>> I think when it's called from dmarcf_config_reload(), it should be called
>> as it's done in opendmarc_policy_library_init(), or at least:
>>
>
> Nice catch!
>

Thank you for the confirmation!


> opendmarc_tld_read_file(new->conf_pslist, NULL, "*.", "!")
>>
>
> Uhm, why that one?


That's because when  opendmarc_tld_read_file() is called with its second
parameter as NULL, these statements are executed:

        if (commentstring == NULL)
                commentstring = "//";


> Should I file a bug? Or I'm missing something here?
>>
>
> Yes, please do so.
>

Done: https://sourceforge.net/p/opendmarc/tickets/186/

  Juri
> _______________________________________________
> opendmarc-dev mailing list
> opendmarc-dev at trusteddomain.org
> http://www.trusteddomain.org/mailman/listinfo/opendmarc-dev
>

Regards,
Federico Omoto
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.trusteddomain.org/pipermail/opendmarc-dev/attachments/20160824/6ba90952/attachment.htm>