[opendmarc-dev] Possible bug in dmarcf_config_reload function

[Juri Haberland]

On 2016-08-24 01:10, Federico Omoto wrote:
> Hi!

Hello Federico,

> When the opendmarc_tld_read_file() is called inside
> opendmarc_policy_library_init(), it's called as:
> 
> opendmarc_tld_read_file(Opendmarc_Libp->tld_source_file, "//", "*.", 
> "!")
> 
> But when it's called from dmarcf_config_reload(), it's called as:
> 
> opendmarc_tld_read_file(new->conf_pslist, "#", NULL, NULL)
> 
> I think when it's called from dmarcf_config_reload(), it should be 
> called
> as it's done in opendmarc_policy_library_init(), or at least:

Nice catch!

> opendmarc_tld_read_file(new->conf_pslist, NULL, "*.", "!")

Uhm, why that one?

> Should I file a bug? Or I'm missing something here?

Yes, please do so.


   Juri