<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Aug 24, 2016 at 4:01 AM, Juri Haberland <span dir="ltr"><<a href="mailto:juri@sapienti-sat.org" target="_blank">juri@sapienti-sat.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 2016-08-24 01:10, Federico Omoto wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Hi!<br>
</blockquote>
<br>
Hello Federico,<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
When the opendmarc_tld_read_file() is called inside<br>
opendmarc_policy_library_init(<wbr>), it's called as:<br>
<br>
opendmarc_tld_read_file(Opendm<wbr>arc_Libp->tld_source_file, "//", "*.", "!")<br>
<br>
But when it's called from dmarcf_config_reload(), it's called as:<br>
<br>
opendmarc_tld_read_file(new->c<wbr>onf_pslist, "#", NULL, NULL)<br>
<br>
I think when it's called from dmarcf_config_reload(), it should be called<br>
as it's done in opendmarc_policy_library_init(<wbr>), or at least:<br>
</blockquote>
<br></span>
Nice catch!<span class=""><br></span></blockquote><div><br></div><div>Thank you for the confirmation!</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
opendmarc_tld_read_file(new->c<wbr>onf_pslist, NULL, "*.", "!")<br>
</blockquote>
<br></span>
Uhm, why that one?</blockquote><div><br></div><div>That's because when  opendmarc_tld_read_file() is called with its second parameter as NULL, these statements are executed:</div><div><br></div><div><div>        if (commentstring == NULL)</div><div>                commentstring = "//";</div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Should I file a bug? Or I'm missing something here?<br>
</blockquote>
<br></span>
Yes, please do so.<br></blockquote><div> </div><div>Done: <a href="https://sourceforge.net/p/opendmarc/tickets/186/">https://sourceforge.net/p/opendmarc/tickets/186/</a></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
  Juri<br>
______________________________<wbr>_________________<br>
opendmarc-dev mailing list<br>
<a href="mailto:opendmarc-dev@trusteddomain.org" target="_blank">opendmarc-dev@trusteddomain.or<wbr>g</a><br>
<a href="http://www.trusteddomain.org/mailman/listinfo/opendmarc-dev" rel="noreferrer" target="_blank">http://www.trusteddomain.org/m<wbr>ailman/listinfo/opendmarc-dev</a><br>
</blockquote></div><br></div><div class="gmail_extra">Regards,</div><div class="gmail_extra">Federico Omoto</div><div class="gmail_extra"><br></div></div>