[opendmarc-users] Patch Comparison and Personal RFC

[Scott Kitterman]

On Monday, December 12, 2016 07:56:57 PM Steve Jenkins wrote:
> Scott, Juri, and anyone else who feels like chiming in (I'm looking at you,
> Andreas):
> 
> I've built this simple spreadsheet showing the patches that each of you
> suggests including in an opendmarc build that you consider "worthy" of
> pushing to stable repos , even though it's built using beta source:
> 
> https://docs.google.com/spreadsheets/d/1bhlYp_A6j_NF6I9cEAoHsYJV06ooEjkDlsMo
> 9v67mtQ/edit?usp=sharing
> 
> As you can see, for the most part, both agree on the majority of the
> patches.
> 
> But before I make a final decision regarding which patches I believe should
> appear in a Fedora/RHEL build, I'd like to hear comments about:
> 
> - why you chose to include a patch that the other one didn't, and
> - why you chose not to include a patch that the other one did

So here's the differences:

https://sourceforge.net/p/opendmarc/tickets/159/

I didn't include it because I didn't have the time to study it.

https://sourceforge.net/p/opendmarc/tickets/168/

I included this one, but in retrospect, probably shouldn't have.  It's a new 
feature and I generally don't think we should be distro patching those in.  I 
don't plan to drop it, since I've shipped it, but I don't particularly 
recommend you add it.

Not sure what I was thinking at the time.

https://sourceforge.net/p/opendmarc/tickets/171/

Seemed low priority, but probably worthwhile including. The only concern is if 
later msk decides to change the code to match the docs rather than change the 
docs to match the code.

https://sourceforge.net/p/opendmarc/tickets/193/

I think I missed this one by accident.

https://sourceforge.net/p/opendmarc/tickets/197/

This one I left alone since there's no telling which of the two msk will keep.  
I thought it better to have two than to remove one and have it change later.

Scott K