[opendmarc-dev] OpenDMARC 1.3.2.Beta1 available

[Juri Haberland]

On 2017-01-30 11:49, Juri Haberland wrote:
> Scott Kitterman wrote:
>> On Saturday, January 28, 2017 07:57:09 AM Murray S. Kucherawy wrote:
>>> > #95   SPF validation fail for ipv6
>>> 
>>> No idea how I missed this one.  There's a git log reference to "Bug 
>>> #95"
>>> (but it seems unrelated) that probably made me think this one had 
>>> already
>>> been handled.  Done now.
>> 
>> For this one, is there a reason you replaced 
>> SPF_request_set_ipv4_str(spfctx-
>>> spf_request, ip_address); with 
>>> SPF_request_set_ipv6_str(spfctx->spf_request,
>> ip_address); rather than adding 
>> SPF_request_set_ipv6_str(spfctx->spf_request,
>> ip_address);?
>> 
>> I was expecting to see:
>> 
>>         /*
>>         * we don't care at this point if it is ipv6 or ipv4
>>         */
>>        SPF_request_set_ipv4_str(spfctx->spf_request, ip_address);
>>        SPF_request_set_ipv6_str(spfctx->spf_request, ip_address);
>>        return 0;

> Scott is right, see also the libspf2 documentation:
> http://www.libspf2.org/docs/html/spfquery_8c-source.html#l00606
> 
> Furthermore the commit that should fix #187 misses the compile fix and 
> the fix
> for the differing log messages (colon vs. no colon)  :(

Another two minor things that got lost (already in Beta1):
- The patch for ticket #197 amongst others removed reports/mkdb.mysql 
and replaced "mkdb.mysql" with "schema.mysql" in reports/README.
In the commit for beta1 only one of the two occurrances was replaced, 
the second one got lost.

- The patch for ticket #189 removed docs/rfc7489.txt and the docs/README 
file that referenced it and replaced both with docs/README.specs.html.
In the commit for beta1 docs/rfc7489.txt was replaced by 
docs/README.specs.html, but the old docs/README file still exists and is 
referenced in docs/Makefile.am.


   Juri