[opendmarc-users] Help with opendmarc_fetch_utilized_domain

[Davide Migliavacca]

Hi all,

I'm probably being a little dense with this question, please be patient.

I'm adding TLD support to the Mail::DMARC::opendmarc perl module and
using opendmarc_fetch_utilized_domain to check it's working as
expected (library initialization in XS modules can be tricky).
However, I'm always getting back the From domain, and the code flow in
opendmarc_policy.c:

	if (pctx->organizational_domain != NULL)
		which = pctx->organizational_domain;
	if (pctx->from_domain != NULL)
		which = pctx->from_domain;

shows the function will return the from_domain unless the from_domain is NULL.
But the from_domain won't normally be NULL in these use cases.

Shouldn't the statements be reversed (if organizational_domain is
non-NULL, it was used during the DMARC discovery) or the second if be
an else if ?

Thanks,
Davide