[opendmarc-dev] OpenDMARC 1.3.2.Beta1 available

[Scott Kitterman]

On Saturday, January 28, 2017 07:57:09 AM Murray S. Kucherawy wrote:
> > #95   SPF validation fail for ipv6
> 
> No idea how I missed this one.  There's a git log reference to "Bug #95"
> (but it seems unrelated) that probably made me think this one had already
> been handled.  Done now.

For this one, is there a reason you replaced SPF_request_set_ipv4_str(spfctx-
>spf_request, ip_address); with SPF_request_set_ipv6_str(spfctx->spf_request, 
ip_address); rather than adding SPF_request_set_ipv6_str(spfctx->spf_request, 
ip_address);?

I was expecting to see:

        /*
        * we don't care at this point if it is ipv6 or ipv4
        */
       SPF_request_set_ipv4_str(spfctx->spf_request, ip_address);
       SPF_request_set_ipv6_str(spfctx->spf_request, ip_address);
       return 0;

not:

        /*
         * we don't care at this point if it is ipv6 or ipv4
         */
        SPF_request_set_ipv6_str(spfctx->spf_request, ip_address);
        return 0;

Scott K