[opendmarc-dev] OpenDMARC 1.3.2.Beta1 available

[Juri Haberland]

On 12.02.2017 00:09, Murray S. Kucherawy wrote:
> On Mon, 30 Jan 2017, Juri Haberland wrote:

>> Murray, please do us a favour and apply the patches that we provide as-is.
> 
> Juri,
> 
> That's always what I try to do, especially if the patch matches current 
> coding style and is clearly understandable by me.  I'm sure you realize 
> that the majority of the patches that get submitted are applied directly 
> without difficulty.
> 
> As I'm also sure you realize, I'm ultimately responsible for this code, so 
> I need to understand the problem and the proposed solution.  If I don't, I 
> must either reject the request until I do, or make an attempt at a better 
> solution.  Sometimes, I realize, that doesn't work out.  It's unfortunate 
> when that's the case, but please don't leap to the conclusion that there's 
> malice or incompetence in play here.


Hey Murray,

yes, that sounded a bit harsh and yes, I was very frustrated that not only
the compile problem wasn't fixed but another problem was introduced - I
just had to get it off my chest... sorry!

Your quote of my mail missed the essential next two sentences:
> If you feel they do something in a way that you don't like, alter it
> after applying the patch. The way you do it now you introduce new
> errors.
My main point was: in case a patch needs work on your side, it might be
less error-prone to apply it as-is and *then* change the outcome to your
needs instead of doing the changes of the patch manually. Some subtle
changes like != vs. |= are easily overlooked.

Nevertheless, good work. Ready for release now, IMO.

  Juri

PS: If you feel brave, have a look at ticket #193 ;)