[opendmarc-dev] draft: patch to implement an override mechanism for MLMs

[Juri Haberland]

On 22.05.2016 19:54, A. Schulze wrote:
>>> - opendmarc crash if OverrideMLM is not set in opendmarc.conf
>>
>> I can't reproduce that here. At least it starts without a problem. Do you
>> see the crash when a message arrives that would be rejected (or quarantined)?
> 
> crash just on start...
> maybe you've fixed that already:
> 
>        str = NULL;
>        (void) config_get(data, "OverrideMLM", &str, sizeof str);

Strange, in the patch I send to the list there is at this place the
following line:

         if (str != NULL)
>        {
>            if (!dmarcf_loadlist(str, &conf->conf_overridemlm))

>> In my opinion it is ok to send a failure report because the message does
>> fail the DMARC test - so send a failure report. But locally we decide to
>> accept it anyway.
> virtually nobody¹) send failure reports to external domain owners.
> But I suggest to send failure reports to a local mailbox.

IMHO it's up to the destination domain owner to decide, whether he wants to
send failure reports, and it's up to the originating domain owner whether
he wants to receive such reports or not.

>>> - I suggest some logging
>>>    result = fail, overwritten by OverrideMLM: pass
> or: result = fail, not rejected because $OverrideMLM
> 
>> Currently it logs something like:
>>>> opendmarc[123]: A5CB71847: overriding policy for mail from lists.ntp.org because of MLM
> also: not visible here. you have a newer patch version I guess.

Nope, exactly the version I posted. Have a look at the patch in my mail:

syslog(LOG_INFO, "%s: overriding policy for mail from %s: MLM",
   dfc->mctx_jobid, domain);

  Juri