[opendmarc-dev] [opendmarc-announce] OpenDMARC 1.3.2 Beta cycle
Steve Jenkins
steve at stevejenkins.com
Wed Jul 20 15:22:43 PDT 2016
On Wed, Jul 20, 2016 at 4:01 PM, Scott Kitterman <sklist at kitterman.com>
wrote:
> On Wednesday, July 20, 2016 03:28:19 PM Steve Jenkins wrote:
> > On Wed, Jul 20, 2016 at 12:00 AM, Scott Kitterman <sklist at kitterman.com>
> >
> > wrote:
> > > It didn't compile for me. Please see the attached patch.
> >
> > Supremely tiny nit here. While looking at Scott's patch for opendmarc.c
> > that fixed the missing quote mark in the DMARC_POLICY_SPF_ORIGIN_HELO, I
> > noted that the two modes addressed in there were either:
> >
> > mode = "helo:"
> >
> > and
> >
> > mode = "mailfrom"
> >
> > The helo has a colon, the mailfrom doesn't (that wasn't introduced by
> > Scott's patch, he was fixing the quote).
> >
> > Apparently it works as-is, but is there a reason why the colon use isn't
> > consistent?
>
> Good question. I didn't look beyond making it build.
Sometimes my OCD comes in handy. LOL.
SteveJ
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.trusteddomain.org/pipermail/opendmarc-dev/attachments/20160720/9812347a/attachment.htm>
More information about the opendmarc-dev
mailing list