[opendmarc-dev] OpenDMARC 1.3.0 Beta3 available

[Scott Kitterman]

On Saturday, July 19, 2014 03:21:23 Scott Kitterman wrote:
> On Tuesday, July 15, 2014 23:39:08 Murray S. Kucherawy wrote:
> > With apologies for the delay since Beta2.  Changes:
> > 
> > o Support for libspf2 added.
> > 
> > o Make "smime" a legal Authentication-Results method.
> > 
> > o Minor opendmarc-reports script fixes.
> > 
> > I'd like to release this one late this week or early next, so please make
> > time to give it a go, especially if you are able to exercise the libspf2
> > code that was just added.  Scott, please let me know whether it meets your
> > requirements.
> 
> Sorry for the delay.
> 
> I've just uploaded packages for the Debian Experimental repository with
> libspf2 support enabled.  All the auto* foo worked fine and the package
> built.
> 
> I have not had a chance to test yet how well it works, but since this is a
> beta and not the final, I wouldn't wait on me.  Maybe someone else has had a
> chance.
> 
> In terms of a reasonable approach, I think with libspf2 support added, I
> think it's good.  I would prefer it be just libspf2 because it seems to
> better match RFC 4408/7208, but I'm not going to get in an argument over
> it.
> 
> Thanks for putting in the effort to get the libspf2 support done for this
> release.

Reviewing the build logs, there are quite a number of implicit declaration 
warnings here (using libbsd):

opendmarc_tld.c:42:2: warning: implicit declaration of function 'strlcpy' [-
Wimplicit-function-declaration]
opendmarc_tld.c:65:3: warning: implicit declaration of function 'strlcat' [-
Wimplicit-function-declaration]
opendmarc_policy.c:243:2: warning: implicit declaration of function 'strlcpy' 
[-Wimplicit-function-declaration]
opendmarc_policy.c:249:3: warning: implicit declaration of function 'strlcat' 
[-Wimplicit-function-declaration]
opendmarc_xml.c:133:2: warning: implicit declaration of function 'strlcpy' [-
Wimplicit-function-declaration]
opendmarc_xml.c:178:6: warning: implicit declaration of function 'strlcat' [-
Wimplicit-function-declaration]
opendmarc_util.c:346:2: warning: implicit declaration of function 'strlcpy' [-
Wimplicit-function-declaration]
config.c:147:5: warning: implicit declaration of function 'strlcpy' [-
Wimplicit-function-declaration]
opendmarc-ar.c:386:4: warning: implicit declaration of function 'strlcat' [-
Wimplicit-function-declaration]
opendmarc-ar.c:416:5: warning: implicit declaration of function 'strlcpy' [-
Wimplicit-function-declaration]
opendmarc-dstring.c:204:2: warning: implicit declaration of function 'strlcpy' 
[-Wimplicit-function-declaration]
opendmarc-dstring.c:247:2: warning: implicit declaration of function 'strlcat' 
[-Wimplicit-function-declaration]
opendmarc.c:969:4: warning: implicit declaration of function 'strlcat' [-
Wimplicit-function-declaration]
opendmarc.c:4484:3: warning: implicit declaration of function 'strlcpy' [-
Wimplicit-function-declaration]
test.c:464:5: warning: implicit declaration of function 'strlcat' [-Wimplicit-
function-declaration]
test.c:514:5: warning: implicit declaration of function 'strlcpy' [-Wimplicit-
function-declaration]
util.c:176:2: warning: implicit declaration of function 'strlcpy' [-Wimplicit-
function-declaration]

In opendkim, you added:

/* libbsd if found */
#ifdef USE_BSD_H
# include <bsd/string.h>
#endif /* USE_BSD_H */

This doesn't seem to have been done for opendmarc.  I can prepare a patch if 
you'd like.

Scott K